lakebox: show "never" when server has no idle_timeout#5321
Merged
akshaysingla-db merged 1 commit intoMay 24, 2026
Merged
Conversation
The CLI was rendering AUTOSTOP as "10m" whenever `idle_timeout` was unset on the wire, claiming to mirror a manager-side `watchdog_idle_grace_secs` fallback. That constant does not exist anywhere in the current tree (only a stale comment in `lakebox/proto/lakebox.proto`); the ESM-side checker that would enforce auto-stop is also gated off via the `lakeboxCheckerEnabled` SAFE flag. So today the "10m" label was cosmetic — sandboxes with unset `idle_timeout` live indefinitely. Render unset/zero as "never" to match what the system actually does, and drop the misleading `defaultAutoStopSecs` constant. Tracking the service-side enforcement work (and the eventual swap-back here) in CJ-75655. Co-authored-by: Isaac
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI was rendering AUTOSTOP as "10m" whenever
idle_timeoutwas unset on the wire, claiming to mirror a manager-sidewatchdog_idle_grace_secsfallback. That constant does not exist anywhere in the current tree (only a stale comment inlakebox/proto/lakebox.proto); the ESM-side checker that would enforce auto-stop is also gated off via thelakeboxCheckerEnabledSAFE flag. So today the "10m" label was cosmetic — sandboxes with unsetidle_timeoutlive indefinitely.Render unset/zero as "never" to match what the system actually does, and drop the misleading
defaultAutoStopSecsconstant. Tracking the service-side enforcement work (and the eventual swap-back here) in CJ-75655.Co-authored-by: Isaac
Changes
Why
Tests